Add CommandGamepad for V3 commands #8311
Open
+813
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamCarlberg
requested changes
Oct 29, 2025
commandsv3/src/main/java/org/wpilib/commands3/button/CommandGamepad.java
Show resolved
Hide resolved
katzuv
reviewed
Oct 29, 2025
commandsv3/src/main/java/org/wpilib/commands3/button/CommandGamepad.java
Outdated
Show resolved
Hide resolved
Comment on lines
+421
to
+432
| public Trigger misc1() { | ||
| return misc1(getScheduler().getDefaultEventLoop()); | ||
| } | ||
|
|
||
| /** | ||
| * Constructs a Trigger instance around the Miscellaneous 1 button's digital signal. | ||
| * | ||
| * @param loop the event loop instance to attach the event to. | ||
| * @return a Trigger instance representing the Miscellaneous 1 button's digital signal attached to | ||
| * the given loop. | ||
| */ | ||
| public Trigger misc1(EventLoop loop) { |
There was a problem hiding this comment.
Shouldn't these be near the other miscellaneous buttons?
There was a problem hiding this comment.
This is the order they're defined in in SDL, and was the way it was generated.
…mepad.java Co-authored-by: Dan Katzuv <31829093+katzuv@users.noreply.github.com>
SamCarlberg
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to add this.