Skip to content

Simplify the public suffix and registrable domain definitions #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2025
Merged

Simplify the public suffix and registrable domain definitions #887

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0ed021
Simplify the public suffix and registrable domain definitions
rmisev Oct 18, 2025
39b2ff7
Add asserts
rmisev Oct 19, 2025
7320a1f
Modify the assertions to check for a trailing dot
rmisev Oct 29, 2025
dac5772
fix
rmisev Oct 29, 2025
e8a672b
nit
annevk Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions url.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,10 +794,10 @@ that is included on the <cite>Public Suffix List</cite>. [[!PSL]]
<a href="https://github.com/publicsuffix/list/wiki/Format#formal-algorithm">Public Suffix List algorithm</a>
with <var>host</var> as domain. [[!PSL]]

<li><p>Assert: <var>publicSuffix</var> is an <a>ASCII string</a> that does not
Copy link
Member

@shannonbooth shannonbooth Oct 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the ASCII assert previously added by c28ff95 - which I think was valuable as an assert as this did clarify behavior for me. But maybe it makes sense to explicitly have a spec note for it that we're using A-label instead of (or in combination of?) an assert?

Copy link
Member Author

@rmisev rmisev Oct 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have returned previously added asserts.

Copy link
Member

@annevk annevk Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep trailingDot and use it in this assert? Like "publicSuffix is an ASCII string that ends with trailingDot"?

I like the additional clarity that gives especially since the Public Suffix specification is rather informal. Hopefully at some point we define Public Suffix in a proper standards body, but until that day...

We should also link "Assert" now that we're changing this.

Copy link
Member Author

@rmisev rmisev Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annevk I made the changes you suggested.

<a for=string>end with</a> "<code>.</code>".
<li><p><a for=/>Assert</a>: <var>publicSuffix</var> is an <a>ASCII string</a> that
<a for=string>ends with</a> <var>trailingDot</var>.

<li><p>Return <var>publicSuffix</var> and <var>trailingDot</var> concatenated.
<li><p>Return <var>publicSuffix</var>.
</ol>
</div>

Expand All @@ -818,10 +818,10 @@ any.
<a href="https://github.com/publicsuffix/list/wiki/Format#formal-algorithm">Public Suffix List algorithm</a>
with <var>host</var> as domain. [[!PSL]]

<li><p>Assert: <var>registrableDomain</var> is an <a>ASCII string</a> that does not
<a for=string>end with</a> "<code>.</code>".
<li><p><a for=/>Assert</a>: <var>registrableDomain</var> is an <a>ASCII string</a> that
<a for=string>ends with</a> <var>trailingDot</var>.

<li><p>Return <var>registrableDomain</var> and <var>trailingDot</var> concatenated.
<li><p>Return <var>registrableDomain</var>.
</ol>
</div>

Expand Down