- 
                Notifications
    
You must be signed in to change notification settings  - Fork 156
 
Simplify the public suffix and registrable domain definitions #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Not terribly impressed that the specification is on a wiki now... publicsuffix/list#792 is where the change was discussed. This PR looks good to me, but I'll wait a bit with merging.  | 
    
| <a href="https://github.com/publicsuffix/list/wiki/Format#formal-algorithm">Public Suffix List algorithm</a> | ||
| with <var>host</var> as domain. [[!PSL]] | ||
| 
               | 
          ||
| <li><p>Assert: <var>publicSuffix</var> is an <a>ASCII string</a> that does not | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes the ASCII assert previously added by c28ff95 - which I think was valuable as an assert as this did clarify behavior for me. But maybe it makes sense to explicitly have a spec note for it that we're using A-label instead of (or in combination of?) an assert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have returned previously added asserts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep trailingDot and use it in this assert? Like "publicSuffix is an ASCII string that ends with trailingDot"?
I like the additional clarity that gives especially since the Public Suffix specification is rather informal. Hopefully at some point we define Public Suffix in a proper standards body, but until that day...
We should also link "Assert" now that we're changing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annevk I made the changes you suggested.
As of April 1, 2025, the Public Suffix List algorithm was modified so that the trailing dot of a domain would be retained in the result. Quotes from this algorithm:
Therefore, there is no need to add a trailing dot to the result if the input domain has one, as this dot is retained by the PSL algorithm.
Preview | Diff