[3] refactor: improve & simplify tree-sitter context-tracking #595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctx.node_under_cursordoes not need to be an Option; we should always have a tree.root_nodeTreesitterContextNext up, I'll make sure we open new scopes for CTEs, subqueries etc.
Also, I think the whole WrappingClause and WrappingNodes are unnecessary indirections – we can just as easily check the tree-sitter node kind
&strs.