Skip to content

[IMPROVEMENT] Fix for Issue #30 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[IMPROVEMENT] Fix for Issue #30 #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f21f9c3
[IMPROVEMENT] Solve issue #30 (hash for big files was not correctly c…
itnok Mar 20, 2015
61d7ed9
[BUG] Syntax error: fileEncoding is an argument of fs.readFileSync
itnok Mar 20, 2015
04d56df
[SETUP] Require Grunt >= 0.4.0
itnok Mar 20, 2015
27d9f71
Merge branch 'master' into patch-1
itnok Mar 20, 2015
568a608
[IMPROVEMENT] Add support for file encoding option
itnok Mar 20, 2015
86d9f3a
[BUG] Forgotten ")" should be removed
itnok Mar 20, 2015
04af16f
[UPDATE] Version bump to v0.1.1
itnok Mar 20, 2015
5afbba2
[UPDATE] Let's use newer releases for dependencies
itnok Mar 20, 2015
8d18cbd
[SETUP] We need at least node 0.9
itnok Mar 20, 2015
7a4a98f
[SETUP] Force Travis CI to use npm version 2.0.0
itnok Mar 20, 2015
4cbdcc9
[SETUP] Test against Node 0.8,0.9,0.10 with npm>2
itnok Mar 20, 2015
693e467
[SETUP] Test against Node 0.8,0.9,0.10
itnok Mar 20, 2015
f4d6b39
[SETUP] grunt-cli is now installed by default on Travis CI
itnok Mar 20, 2015
a302ec9
[SETUP] Dropping tests on node < 0.10
itnok Mar 20, 2015
96b492e
[SETUP] Changes for dropping tests on node < 0.10
itnok Mar 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
language: node_js
node_js:
- "0.8"
- "0.10"
before_script:
- npm update -q
- npm --version
- npm install -g grunt-cli
14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "grunt-rev",
"description": "Static file asset revisioning through content hashing",
"version": "0.1.0",
"version": "0.1.1",
"homepage": "https://github.com/cbas/grunt-rev",
"author": {
"name": "Sebastiaan Deckers",
Expand All @@ -23,17 +23,17 @@
],
"main": "Gruntfile.js",
"engines": {
"node": ">= 0.8.0"
"node": ">= 0.10.0"
},
"scripts": {
"test": "grunt test"
},
"devDependencies": {
"grunt-contrib-copy": "0.4.0",
"grunt-contrib-jshint": "0.1.1rc6",
"grunt-contrib-clean": "0.4.0rc6",
"grunt-contrib-nodeunit": "0.1.2rc6",
"grunt": "0.4.0rc6"
"grunt-contrib-copy": ">=0.8.0",
"grunt-contrib-jshint": ">=0.11.1",
"grunt-contrib-clean": ">=0.6.0",
"grunt-contrib-nodeunit": ">=0.4.1",
"grunt": ">=0.4.0"
},
"keywords": [
"gruntplugin"
Expand Down
6 changes: 4 additions & 2 deletions tasks/rev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ var fs = require('fs'),
module.exports = function(grunt) {

function md5(filepath, algorithm, encoding, fileEncoding) {
var hash = crypto.createHash(algorithm);
var hash = crypto.createHash(algorithm),
fsOptions = {encoding: fileEncoding};

grunt.log.verbose.write('Hashing ' + filepath + '...');
hash.update(grunt.file.read(filepath), fileEncoding);
hash.update(fs.readFileSync(filepath, fsOptions), fileEncoding);
return hash.digest(encoding);
}

Expand Down