[IMPROVEMENT] Fix for Issue #30 #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly calculated) The `fs` library is already included and it looks like it works better than `grunt.file`. With files bigger than few kilobytes the hash is calculated in the right way. It looks like `grunt.file.read` either does not read the file correctly or not in full. This change solves Issue sebdeckers#30
Oops! Sorry... :-)
Signed-off-by: Simone Conti <s.conti@itnok.com>
Default to UTF-8 Signed-off-by: Simone Conti <s.conti@itnok.com>
Signed-off-by: Simone Conti <s.conti@itnok.com>
- Updating to v0.1.1 This will permit npm to better track changes and let user download the latest version. Signed-off-by: Simone Conti <s.conti@itnok.com>
Perhaps even not release candidate versions... Signed-off-by: Simone Conti <s.conti@itnok.com>
Let's see if Travis CI like it a little bit more this way... Signed-off-by: Simone Conti <s.conti@itnok.com>
npm version 2.0.0 is the first where the "caret bug" was removed: ^0.x.y is now functionally the same as ~0.x.y Signed-off-by: Simone Conti <s.conti@itnok.com>
Signed-off-by: Simone Conti <s.conti@itnok.com>
Update npm before script starts to avoid troubles with "^" in packages requirements. npm can be newer that node... and it actually should. Signed-off-by: Simone Conti <s.conti@itnok.com>
Signed-off-by: Simone Conti <s.conti@itnok.com>
It also looks like grunt-cli installation is mandatory Signed-off-by: Simone Conti <s.conti@itnok.com>
We are dropping tests on node < 0.10.0 We are alos using updated dependencies We should be modern, right?! Signed-off-by: Simone Conti <s.conti@itnok.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem/BUG => hash for big files was not correctly calculated
The
fslibrary is already included and it looks like it works better thangrunt.file.With files bigger than few kilobytes the hash is now calculated in the right way.
It looks like
grunt.file.readeither does not read the file correctly or not in full.This change solves Issue #30