Skip to content

Code quality improvements #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Code quality improvements #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions imdlib/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import numpy as np
import pandas as pd
import os
import sys
import requests
import xarray as xr
from imdlib.util import LeapYear, get_lat_lon, total_days, get_filename
Expand Down Expand Up @@ -109,7 +108,7 @@ def to_csv(self, file_name=None, lat=None, lon=None, out_dir=None):
raise Exception("Error in given lat coordinates."
"Given lat value is not in the IMD data range!! ")
if lon > max(self.lon_array) and lon < min(self.lon_array):
raise Exception("Error in in given lon coordinates."
raise Exception("Error in given lon coordinates."
"Given lon value is not in the IMD data range!! ")

if lat is None and lon is None:
Expand Down Expand Up @@ -200,7 +199,7 @@ def get_xarray(self):
xr_da_masked.time.attrs['long_name'] = 'time'

xr_da_masked.lon.attrs['axis'] = 'X' # Optional
xr_da_masked.lon.attrs['long_name'] = 'longitude'
xr_da_masked.lon.attrs['standard_name'] = 'longitude'
xr_da_masked.lon.attrs['long_name'] = 'longitude'
xr_da_masked.lon.attrs['units'] = 'degrees_east'

Expand Down
2 changes: 1 addition & 1 deletion imdlib/naming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
}

# Dictionary of functions
# Representing untits in netcdf data
# Representing units in netcdf data

units_dic_anu = {
"cwd": "Days",
Expand Down
1 change: 0 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def readme():
'numpy',
'pandas',
'six',
'pandas',
'python-dateutil',
'pytz',
'urllib3',
Expand Down