Code quality improvements #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple small code quality fixes: 1. Remove duplicate pandas dependency in setup.py 2. Add missing standard_name attribute for longitude in core.py (matching latitude pattern) 3. Remove unused sys import in core.py 4. Fix typo in comment: 'untits' → 'units' in naming.py 5. Fix typo in exception message: 'Error in in given' → 'Error in given' in core.py These changes improve code cleanliness and professionalism without affecting functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Multiple small code quality fixes to improve code cleanliness and professionalism.
Changes
1. Remove duplicate pandas dependency
File:
setup.pyPandas was listed twice in
install_requireslist.2. Add missing standard_name for longitude
File:
imdlib/core.py(line 202)Added
standard_nameattribute for longitude to match the latitude pattern.3. Remove unused sys import
File:
imdlib/core.py(line 9)The
sysmodule was imported but never used.4. Fix typo in comment
File:
imdlib/naming.py(line 44)Fixed comment: "Representing untits in netcdf data" → "Representing units in netcdf data"
5. Fix typo in exception message
File:
imdlib/core.py(line 111)Fixed error message: "Error in in given lon" → "Error in given lon"
All changes are cosmetic and do not affect functionality.