Skip to content

Use crypto/sha256 instead of crypto/md5 for FIPS compliance. #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2025
+6 −7
Merged

Use crypto/sha256 instead of crypto/md5 for FIPS compliance. #1056

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
605a69e
Use crypto/sha256 instead of crypto/md5 for FIPS compliance.
BillBuilt Sep 24, 2025
37b7419
update comment to match changes
BillBuilt Sep 29, 2025
ba9898e
revert
BillBuilt Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ package resty

import (
"bytes"
"crypto/md5"
"crypto/rand"
"crypto/sha256"
"encoding/binary"
"encoding/hex"
"errors"
Expand Down Expand Up @@ -371,7 +371,7 @@ func newGUID() string {
// Timestamp, 4 bytes, big endian
binary.BigEndian.PutUint32(b[:], uint32(time.Now().Unix()))

// Machine, first 3 bytes of md5(hostname)
// Machine, first 3 bytes of sha256.Sum256([]byte(hostname))
b[4], b[5], b[6] = machineID[0], machineID[1], machineID[2]

// Pid, 2 bytes, specs don't specify endianness, but we use big endian.
Expand Down Expand Up @@ -403,13 +403,12 @@ var osHostname = os.Hostname
// readMachineID generates and returns a machine id.
// If this function fails to get the hostname it will cause a runtime error.
func readMachineID() []byte {
var sum [3]byte
id := sum[:]
const idSize = 3
id := make([]byte, idSize)

if hostname, err := osHostname(); err == nil {
hw := md5.New()
_, _ = hw.Write([]byte(hostname))
copy(id, hw.Sum(nil))
hash := sha256.Sum256([]byte(hostname))
copy(id, hash[:idSize])
return id
}

Expand Down