-
-
Notifications
You must be signed in to change notification settings - Fork 772
Use crypto/sha256 instead of crypto/md5 for FIPS compliance. #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
|
Not only for fips, many linters now suggest avoiding md5 for any reason. |
|
The comment in line 374 should be updated to not reference md5. What are the implications of this change? From what I can see, the machine ID is only used here: Line 375 in 66256ef
Which is only called from here: Line 1385 in 66256ef
|
|
When running go code using https://go.dev/doc/security/fips140 I will update the comment. Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #1056 +/- ##
==========================================
+ Coverage 99.82% 99.85% +0.02%
==========================================
Files 18 18
Lines 3919 3360 -559
==========================================
- Hits 3912 3355 -557
+ Misses 5 3 -2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeevatkm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BillBuilt Thanks for the PR. I'm sorry for the delayed response, I was occupied with my personal stuff.
Can you please revert the go.{mod, sum} file changes?
Use crypto/sha256 instead of crypto/md5 for FIPS compliance.
Update deps