-
-
Notifications
You must be signed in to change notification settings - Fork 236
Drop support for EOL Python 3.9 #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+54
−925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. Thanks @hugovk
I would suggest removing these targets. They have not been built in CI for a long while and AFAIK have never been released. |
|
I had removed iOS/tvOS/watchOS stuff from patch files such as python-build-standalone/cpython-unix/patch-apple-cross.patch Lines 9 to 17 in bdabbfb
|
jjhelmus
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass for #841.
There's some
3.9still left in https://github.com/hugovk/python-build-standalone/blob/main/cpython-unix/targets.yml because seven targets only support 3.9, likeaarch64-apple-iosandarm64-apple-tvos:https://github.com/hugovk/python-build-standalone/blob/2181bddcc918f14275232ad6d1365035f2ae75c4/cpython-unix/targets.yml#L114-L119
Should they be removed? Or upgraded?
Also ran
ruff check --select UP --target-version py310 --fixandrun check --fix. There's a lot of--unsafe-fixesthat can be applied, but they can be in their own PR to avoid making this too big.