AP_RangeFinder_MaxsonarI2CXL: Take device semaphore before interacting with i2c device #31384
+75
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/rangefinder-i2c-baseclass-maxbotix
branch
2 times, most recently
from
513ce1c to
c2612e8
Compare
peterbarker
force-pushed
the
pr/rangefinder-i2c-baseclass-maxbotix
branch
from
c2612e8 to
9760c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also introduces a base class for I2C rangefinders, which is what this branch was about.
Saved 16 bytes before adding the required take-semaphore.
I've tested that at least one other backend fits into the new framework well.
The last patch matches the PR title.