Skip to content

Conversation

@peterbarker
Copy link
Contributor

I've checked the apm.pdef.xml delta for each of the vehicles and they get something like this:

--- AntennaTracker.pdef.xml     2025-10-25 10:12:32.832725851 +1100
+++ AntennaTracker-new.pdef.xml 2025-10-25 10:12:23.367843119 +1100
@@ -12267,6 +12267,24 @@
       </param>
     </parameters>
     <parameters name="GEN_">
+      <param humanName="Seconds until maintenance required" name="GEN_MNT_TIME" documentation="Seconds until maintenance required" user="Advanced">
+</param>
+      <param humanName="Total runtime" name="GEN_RUNTIME" documentation="Total time this generator has run in seconds" user="Advanced">
+</param>
+      <param humanName="High Idle throttle" name="GEN_IDLE_TH_H" documentation="throttle value to use when warming up or cooling down" user="Advanced">
+</param>
+      <param humanName="Idle throttle" name="GEN_IDLE_TH" documentation="throttle value to use when idling" user="Advanced">
+</param>
+      <param humanName="Run Temperature" name="GEN_RUN_TEMP" documentation="temperature required for generator to start producing power in deg celsius" user="Advanced">
+</param>
+      <param humanName="Idle Temperature" name="GEN_IDLE_TEMP" documentation="temperature required for generator to return to idle after having run" user="Advanced">
+</param>
+      <param humanName="Cylinder Head Over Temperature Warning Level" name="GEN_OVER_TEMP" documentation="threshold temperature for the cylinder head above which the mavlink over temperature message gets sent" user="Advanced">
+        <field name="Units">degC</field>
+        <field name="UnitText">degrees Celsius</field>
+      </param>
+    </parameters>
+    <parameters name="GEN_">
       <param humanName="Generator type" name="GEN_TYPE" documentation="Generator type" user="Standard">
         <values>
           <value code="0">Disabled</value>

Not sure we shouldn't fix this - wouldn't be hard for the backends to collide on parameter names if they don't already.

this is where a subgroupvarptr has an empty name so the parameters for a backend appear in the same namespace as the library.

For example, in Generator we have

GEN_TYPE to specify the backend type
GEN_MNT_TIME for the loweheiser backend to specify time-since-last-maintenance
these should be the same as the prefix in the actual parameter construction
@Hwurzburg
Copy link
Contributor

@peterbarker can we get this merged?

@peterbarker
Copy link
Contributor Author

@peterbarker can we get this merged?

If someone approves it, yes. Thems the rules.

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested locally and it does what its supposed to do

@peterbarker peterbarker merged commit 3ed772b into ArduPilot:master Oct 31, 2025
106 checks passed
@peterbarker peterbarker deleted the pr/loweheiser-parameters branch October 31, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants