fixing broken ui layout for create new instance #222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@shrunyan V2
|
agalin920
reviewed
Apr 22, 2022
|
|
||
| <main className={styles.siteList}> | ||
| {props.sites.length === 0 && <WebsiteCreate />} | ||
| {props.sitesFiltered.length === 0 && <WebsiteCreate />} |
There was a problem hiding this comment.
Couldn't the call to action to create a website when there are no filtered results misleading? I think the current UX of only showing 'No Results' when filters are applied make more sense
Contributor
Author
|
closing new PR here #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221 Fix broken layout for new sign up instance
columns and grid view