Skip to content

Conversation

@ICantMakeThings
Copy link

@ICantMakeThings ICantMakeThings commented Nov 7, 2025

not sure if this will be pulled as it requires being pulled in 2 other repos.

more specifically these 2 pr's:

adafruit/Adafruit_nRF52_Arduino#857
platformio/platform-nordicnrf52#211

the repo is from here

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Hello @ICantMakeThings, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

@xudongzheng
Copy link
Contributor

xudongzheng commented Nov 7, 2025

See promicro_nrf52840.

@ICantMakeThings
Copy link
Author

oh mad sorry, i think this is zephyr exclusive as i dont recall it being in platformio, should i close the pr?

Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not accept or support boards in hwmv1 format

@ICantMakeThings
Copy link
Author

now I'm not sure, as promicro_nrf52840 already exists, should I close the PR? or change the defines to support a newer hwm version and this will get merged? no point to update it if it won't even get pulled.

@nordicjm
Copy link
Contributor

If the board you are submitting already exists in tree then yes, close PR, if it is a different board or variant then it can be submitted but this PR would need to be updated to be in hwmv2 format

@ICantMakeThings
Copy link
Author

thaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants