Pr try steps block #291
Merged
Pr try steps block #291
+719
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…face into pr_try_steps_block
lizlooney
requested changes
Oct 27, 2025
lizlooney
requested changes
Oct 28, 2025
lizlooney
reviewed
Oct 30, 2025
lizlooney
requested changes
Oct 30, 2025
… into pr_try_steps_block
Initialize mrcStepNames to [].
Removed "if (state && state.stepNames) {" from loadExtraState.
Add braces to if statements.
Changed python code that checks whether _initialize_steps has been set.
Added createStepsBlocks function to create the steps block for the toolbox.
In methods_category.ts:
Modified MethodsCategory.methodsFlyout to call createStepsBlocks to create the mrc_steps block for the toolbox.
lizlooney
reviewed
Oct 31, 2025
Addressed most of my comments on PR 291
Added renameSteps function. In mrc_step_container: Added conditionShadowState, conditionTargetConnection, statementTargetConnection to StepItemMixin. In mrc_steps: Renamed INPUT_STEP_PREFIX to INPUT_STATEMENT_PREFIX. Added saveConnections method to keep track of connections during mutation. (This is what blockly's controls_if block does.) Changed compose method to reconnect connections. (This is what blockly's controls_if block does.) Call renameSteps (from mrc_jump_to_step) when steps are renamed. Changed updateShape_ to remove all inputs and create new ones. (This is what blockly's controls_if block does.)
|
I created alan412#18 to reconnect the blocks if they are reordered. |
lizlooney
requested changes
Nov 4, 2025
Renamed paramName (createStepFieldFlydown parameter) to stepName. Removed export from createParameterBlock and createJumpToStepBlock.
Reconnect blocks if steps are reordered
lizlooney
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a steps block to opmodes that create a steps method for an easier way for students to create their autonomous opmodes.
There are two changes I know need to be made after this PR.