Generate "from <module> import <name>" import statements #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ClassNameComponent.tsx, check whether the class name entered by the user would cause a collision with an existing python module.
…face into pr_from_x_import_y
alan412
requested changes
Oct 25, 2025
…face into pr_from_x_import_y
|
Yes, at least for this PR, I'm not changing the python code generated for blocks, except for the mrc_port block, where it has multiple names to import from port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate "from import " import statements.
Also, don't let the user create a module whose name collides with an existing python module.
Fixes #234