feat: improve lefthook plugin
#1285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nyarthan
commented
Oct 3, 2025
nyarthan
commented
- include all valid configuration file locations / extensions
- enable plugin if config exists (I think it's common enough to install lefthook via a different method than as a node module e.g. in a nix setup)
commit: |
webpro
reviewed
Oct 5, 2025
| ]; | ||
|
|
||
| const isEnabled: IsPluginEnabled = async ({ dependencies, cwd }) => | ||
| Boolean(hasDependency(dependencies, enablers) || (await _firstGlob({ cwd, patterns }))); |
There was a problem hiding this comment.
The issue with enabling the plugin by config file existence is that we'll no longer be able to determine the opposite: how can we mark the dependency as unused in the future (as it is still often listed)?
There was a problem hiding this comment.
That makes sense - maybe we need another way of "force enabling" a plugin for these cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.