Skip to content

Sroberge/0 4 2 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

Sroberge/0 4 2 #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b80876
don't add undefined object to selection
vim-sroberge Jun 17, 2025
ae1a32d
2d objecet cleanup. don't delete on iterator
vim-sroberge Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vim-web/core-viewers/shared/selection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ export class Selection<T extends IVimElement>{
add(objects: T[]): void;
add(objectOrObjects: T | T[]): void {
if(!this.enabled) return;
if(!objectOrObjects) return;
const objects = this.toArray(objectOrObjects);
let changed = false;

Expand Down
2 changes: 1 addition & 1 deletion src/vim-web/core-viewers/webgl/viewer/rendering/renderScene.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class RenderScene {
private unparent2dObjects (target : THREE.Object3D) {
// A quirk of css2d object is they need to be removed individually.
if (target instanceof THREE.Group) {
for (const child of target.children) {
for (const child of [...target.children]) {
if (child instanceof CSS2DObject) {
target.remove(child)
}
Expand Down