-
Notifications
You must be signed in to change notification settings - Fork 3
Add support for building Android x86 dependencies #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
what is the use case? So far nobody needed that |
|
To be able to run VCMI on old PC with installed Android x86. |
|
it seems that you're the only person who needs that :) in such case I'd suggest to build dependencies and VCMI on your own (on local machine, via GitHub Actions, etc.) without adding the support burden to the project. if you need help with testing on a 32-bit ARM android, just ask. |
|
What's problem with adding Android x86 support for VCMI? You don't need to do it yourself, it's already done in PR. |
|
maintenance burden for a platform that nobody uses. If its build starts failing in the future, who will investigate that? Do you wish to be Android x86 maintainer? adding profiles to the repo is OK of course. |
|
Let's see how it goes. I'm open to investigate it when needed, disabling failing job in future is mostly easy. |
|
Not highest priority, but In general it would be good to have full support as there are some users. Chromebook users usually just install VCMI from play store (I know - they can also use linux, but that is rather an power user thing). |
|
Chromebooks run x86_64 (or arm), not x86. Don't see much point to provide x86 builds in 2025 |
Ah, sorry. Absolutely right! Yes. x86 android doesn't make much sense in 2025. |
|
It's still a solution for old x86 machines for browsing internet. |
Added minimal changes to support Android x86.
Opus fix were added, because all builds fails currently without that. Have zero experience in this area, but managed to make it compile dependencies again.