Feat virtual scroll #1895
Open
Feat virtual scroll #1895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the varletjs Team on Vercel. A member of the Team first needs to authorize it. |
@varlet/cli
@varlet/icons
@varlet/import-resolver
@varlet/preset-tailwindcss
@varlet/preset-unocss
@varlet/shared
@varlet/touch-emulator
@varlet/ui
@varlet/use
@varlet/vite-plugins
commit: |
rzzf
reviewed
Jul 4, 2025
| height: 56px; | ||
| box-sizing: border-box; | ||
| border-bottom: 1px solid rgba(0, 0, 0, 0.05); | ||
| color: #333; |
rzzf
reviewed
Jul 4, 2025
| const containerStyle = computed(() => { | ||
| if (props.containerHeight) { | ||
| return { | ||
| height: typeof props.containerHeight === 'number' ? `${props.containerHeight}px` : props.containerHeight, |
There was a problem hiding this comment.
- height: typeof props.containerHeight === 'number' ? `${props.containerHeight}px` : props.containerHeight,
+ height: `${ toPxNum(props.containerHeight)}px `使用 toPxNum import { toPxNum } from '../utils/elements'
rzzf
reviewed
Jul 4, 2025
| }, | ||
| containerHeight: { | ||
| type: [Number, String], | ||
| default: null, |
| if (!contentRef.value) { | ||
| return | ||
| } | ||
| const nodes = Array.from(contentRef.value.childNodes).filter((node: Node) => node.nodeType === 1) as HTMLElement[] |
There was a problem hiding this comment.
node.nodeType === Node.ELEMENT_NODE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
List of tasks you have already done and plan to do.
Change information
Describe your modifications here.
Issues
The issues you want to close, formatted as close #1.
Related Links
Links related to this pr.