Blog post: How to Properly Secure Your Valkey Deployment #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Bump @madolson or @stockholmux for review |
Member
|
On it now! Sorry for the delay, some work fires recently :) |
madolson
reviewed
Nov 7, 2025
Member
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
I like the structure, some nits and misc recommendations, but I think it's close.
content/blog/2025-10-15-properly-secure-your-valkey-deployment.md
Outdated
Show resolved
Hide resolved
content/blog/2025-10-15-properly-secure-your-valkey-deployment.md
Outdated
Show resolved
Hide resolved
content/blog/2025-10-15-properly-secure-your-valkey-deployment.md
Outdated
Show resolved
Hide resolved
content/blog/2025-10-15-properly-secure-your-valkey-deployment.md
Outdated
Show resolved
Hide resolved
content/blog/2025-10-15-properly-secure-your-valkey-deployment.md
Outdated
Show resolved
Hide resolved
content/blog/2025-10-15-properly-secure-your-valkey-deployment.md
Outdated
Show resolved
Hide resolved
Author
|
Thank you for the thorough review, @madolson! I just pushed a change that incorporates all your feedback 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blog post: How to Properly Secure Your Valkey Deployment
Issues Resolved
#388
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.