fix bugs #12
Merged
fix bugs #12
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| func_code += f" if {py_name_safe} is not None:\n" | ||
| func_code += f" args['{orig_name}'] = {py_name_safe}\n" | ||
| func_code += f" return await bridge.client.call_tool('{get(tool, 'name')}', args)\n" | ||
| func_code += f" return await client.call_tool('{get(tool, 'name')}', args)\n" |
Contributor
There was a problem hiding this comment.
Tool name is inserted into generated code without escaping; a single quote in the name will break the generated function string.
Prompt for AI agents
Address the following comment on web_ui_utcp_mcp_bridge/src/utcp_proxy_mcp.py at line 86:
<comment>Tool name is inserted into generated code without escaping; a single quote in the name will break the generated function string.</comment>
<file context>
@@ -83,10 +83,10 @@ def get(obj, attr, default=None):
func_code += f" if {py_name_safe} is not None:\n"
func_code += f" args['{orig_name}'] = {py_name_safe}\n"
- func_code += f" return await bridge.client.call_tool('{get(tool, 'name')}', args)\n"
+ func_code += f" return await client.call_tool('{get(tool, 'name')}', args)\n"
# Create function
</file context>
Suggested change
| func_code += f" return await client.call_tool('{get(tool, 'name')}', args)\n" | |
| func_code += f" return await client.call_tool({get(tool, 'name')!r}, args)\n" |
| func_code += f" if {py_name_safe} is not None:\n" | ||
| func_code += f" args['{orig_name}'] = {py_name_safe}\n" | ||
| func_code += f" return await bridge.client.call_tool('{get(tool, 'name')}', args)\n" | ||
| func_code += f" return await client.call_tool('{get(tool, 'name')}', args)\n" |
Contributor
There was a problem hiding this comment.
Generated proxy references client, but exec assigns it only to locals; at runtime client is not in the function's globals, causing NameError when the proxy is called.
Prompt for AI agents
Address the following comment on web_ui_utcp_mcp_bridge/src/utcp_proxy_mcp.py at line 86:
<comment>Generated proxy references client, but exec assigns it only to locals; at runtime client is not in the function's globals, causing NameError when the proxy is called.</comment>
<file context>
@@ -83,10 +83,10 @@ def get(obj, attr, default=None):
func_code += f" if {py_name_safe} is not None:\n"
func_code += f" args['{orig_name}'] = {py_name_safe}\n"
- func_code += f" return await bridge.client.call_tool('{get(tool, 'name')}', args)\n"
+ func_code += f" return await client.call_tool('{get(tool, 'name')}', args)\n"
# Create function
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11 and some other stuff
Summary by cubic
Expose the MCP bridge externally and fix tool invocation in generated proxies to prevent call failures. Fixes #11.