Skip to content

Conversation

@CalebZ9909
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue.

Fixes # (issue)

Type of Change

  • Bug fix
  • New feature
  • Documentation update

How Has This Been Tested?

Include any tests here.

  • Unit tests
  • Integration tests
  • Manual testing

Checklist

  • My code follows the style guidelines, e.g. format.sh.
  • I have run build_and_install.sh to verify compilation.
  • I have removed redundant variables and comments.
  • I have updated the documentation.
  • I have added tests.

@YangZhou1997
Copy link
Member

Is this supposed to replace the bench/utils.py, bench/buffer.py? has the various test (test_intranode, test_low_latency, test_internode) worked with this ?

@CalebZ9909
Copy link
Collaborator Author

CalebZ9909 commented Oct 30, 2025

Yes, we will have a specific folder for those but they are equivalent now, those in the bench are copy of that, future modifications will base on the ones in this new folder. I am still running the inter and intra tests. Also sglang integration side saw some issues when running the test and I will talk with them then do the rest of the completed wrap up work.

@MaoZiming
Copy link
Member

is there a way to avoid duplicating buffer.py and utils.py?

@MaoZiming
Copy link
Member

I think the sglang integration test should largely work now. See #496

@CalebZ9909
Copy link
Collaborator Author

Yes, we can keep the original one or move to the new folder to put all the wrappers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants