Skip to content

Demote with parameter #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Demote with parameter #20

wants to merge 9 commits into from

Conversation

@odr
Copy link
Member

@odr odr commented Apr 9, 2019

The main changes:

  • using type parameters to demote types transparently
  • compile cycle was removed
  • support for ghc from 8.2 to 8.6 (lts-10.0 - lts 13.7)

dredozubov
dredozubov reviewed Apr 9, 2019
View reviewed changes
Copy link
Contributor

@dredozubov dredozubov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch looks good! I've left a few comments to address though.

dredozubov
dredozubov reviewed Apr 9, 2019
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dredozubov dredozubov dredozubov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@odr @dredozubov