-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: tmp allows arbitrary temporary file / directory write via symbolic link dir parameter
#15452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR addresses Dependabot Alert 255 by upgrading zapier-platform-cli from 15.4.1 to 17.9.1, which transitively updates the vulnerable tmp package from 0.2.1/0.2.3 to 0.2.4/0.2.5. The vulnerability (CVE) allowed arbitrary temporary file/directory writes via symbolic link attacks on the dir parameter.
Key changes:
- Updated
zapier-platform-clidev dependency (major version bump from 15 to 17) - Transitive update of
tmppackage to patched versions (0.2.4+) - Multiple Babel and oclif dependencies updated as part of CLI upgrade
Impact:
- Security: Fixes critical symlink vulnerability in temporary file operations
- Runtime: No impact -
zapier-platform-cliis a dev dependency used only for build/validation/deployment - Compatibility: CLI v17 should work with existing
zapier-platform-corev15.5.1, though version alignment may need verification
Confidence Score: 4/5
- This PR is safe to merge with minimal risk - it addresses a security vulnerability through a dev dependency upgrade
- Score reflects that the security fix is appropriate and the CLI is only a dev dependency (no runtime impact). One point deducted due to: (1) major version jump from CLI 15→17 without testing validation, and (2) potential metadata mismatch in
convertedByCLIVersionfield that may need verification - Verify that
packages/twenty-zapier/package.jsonline 13 (convertedByCLIVersion) metadata is correct, and test that CLI v17 commands (zapier validate,zapier push) work correctly with core v15
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| packages/twenty-zapier/package.json | 4/5 | Updated zapier-platform-cli from 15.4.1 to 17.9.1 to pull in fixed tmp 0.2.4 |
| yarn.lock | 4/5 | Updated lockfile with zapier-platform-cli 17.9.1 dependencies including tmp 0.2.4 and other transitive dependency updates |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Package as twenty-zapier/package.json
participant Yarn as yarn.lock
participant CLI as zapier-platform-cli
participant Tmp as tmp package
Note over Dev,Tmp: Security Vulnerability Fix (CVE)
Dev->>Package: Update zapier-platform-cli: 15.4.1 → 17.9.1
Package->>Yarn: Run yarn install
Yarn->>CLI: Resolve zapier-platform-cli@17.9.1
CLI->>Tmp: Depend on tmp@0.2.4 (patched)
Tmp-->>CLI: Provides secure temp file handling
CLI-->>Yarn: Install with all dependencies
Yarn->>Yarn: Update tmp: 0.2.1/0.2.3 → 0.2.4/0.2.5
Yarn-->>Package: Lock dependencies
Note over Tmp: tmp@0.2.4+ fixes symlink vulnerability<br/>Prevents arbitrary file/directory writes
Additional Comments (1)
-
packages/twenty-zapier/package.json, line 12-14 (link)style: Check if
convertedByCLIVersionneeds updating to match the new CLI version (17.9.1). The metadata still references the old 15.4.1 version
1 file reviewed, 1 comment
|
Dependabot Alert 78, Dependabot Alert 79 and Dependabot Alert 80 are also caused by |
|
Upon further research, we also need to update
I can move the update to both |
…esolve conflicts.
|
@mabdullahabaid sorry for the slow review about this one, we should have merged it earlier, now we have a conflict in yarn.lock. Could you make the change to v17 and make sure that we are still able to build and publish zapier extension? This was the main thing holding up from merging it, we were not sure that we will still be able to modify our zapier extension after your changes. @martmull can you give a hand here if needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm

Resolves Dependabot Alert 255 - fix: tmp allows arbitrary temporary file / directory write via symbolic link
dirparameter.Updated the dev-dependency
zapier-platform-clifor it to depend on tmp 0.2.4 and also ranyarn up tmp --recursiveto update the version of tmp elsewhere.Not expecting any breaking changes to twenty-zapier since
zapier-platform-cliis marked as a development dependency.