[Update] Added Forbidden Response Check in PagerDuty Detector Verification #4521
+16
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Improved PagerDuty detector logic for credential validation.
Added handling for PagerDuty’s 403 Forbidden response for API tokens which are valid but do not have access to the resource:
If the 403 response body contains the string "Access Denied" and the code "2010", the detector now treats this specific case as a successful credential validation (
return true, nil).Any other 403 response will return an unverified response with verification error since credential validity can’t be confirmed.
Checklist:
make test-community)?make lintthis requires golangci-lint)?