Skip to content

chore: fix feature support to append user agent suffix #4520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 4, 2025
Merged

chore: fix feature support to append user agent suffix #4520

merged 4 commits into from
Nov 4, 2025
+3 −0

Conversation

@dmdhrumilmistry
Copy link
Contributor

@dmdhrumilmistry dmdhrumilmistry commented Oct 29, 2025 •
edited
Loading

Description:

fixes missing feature support append suffix to TruffleHog User Agent header while using --user-agent-suffix flag.

Feature implementation was missed in this PR: https://github.com/trufflesecurity/trufflehog/pull/2208/files

Checklist:

  • Tests passing (make test-community)?
image

@dmdhrumilmistry dmdhrumilmistry requested a review from a team as a code owner October 29, 2025 14:19
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dmdhrumilmistry dmdhrumilmistry mentioned this pull request Oct 31, 2025
Open
kashifkhan0771
kashifkhan0771 reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test this with both live and non-live credentials to ensure everything functions correctly. We want to avoid any risk of breaking an existing detector.

@dmdhrumilmistry
Copy link
Contributor Author

dmdhrumilmistry commented Nov 4, 2025 •
edited
Loading

Please test this with both live and non-live credentials to ensure everything functions correctly. We want to avoid any risk of breaking an existing detector.

Test Cases Output Gist: https://gist.github.com/dmdhrumilmistry/d84bcdd70f5dd47e204eebea845ed310

kashifkhan0771
kashifkhan0771 approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will check with team if we can merge this.

@kashifkhan0771 kashifkhan0771 merged commit fa512d5 into trufflesecurity:main Nov 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camgunz camgunz camgunz approved these changes

@kashifkhan0771 kashifkhan0771 kashifkhan0771 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmdhrumilmistry @CLAassistant @camgunz @kashifkhan0771