Skip to content

Allow for geo-3d integration – Part 1: Refactor and Document #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Allow for geo-3d integration – Part 1: Refactor and Document #44

wants to merge 46 commits into from

Conversation

@TimTheBig
Copy link
Contributor

@TimTheBig TimTheBig commented Mar 28, 2025 •
edited
Loading

This is part 1 of #36, it will:

  • Document all modules and structs.
  • Move main.rs to examples/, split for maximum usefulness. And the example shape functions to a mod behind a the shapes feature.
  • Move shapes in readme to separate file
  • Add error types and handling

TimTheBig added 30 commits March 28, 2025 13:09
@TimTheBig
Replace no_run with ignore
0534648 
Since no_run compiles but doesn't run.
@TimTheBig
Fix use of feature gated deps in parallel
327ea47
@TimTheBig
Fix mistakes and document more code
8ba5d17
@TimTheBig
Fix tests
5dac830
@TimTheBig
Update dependencies
17a3265
@TimTheBig
lint
a9bb15e
@TimTheBig
Update ttf-utils
006644a
@TimTheBig
Add msrv
5161860 
Found with cargo msrv
@TimTheBig
Organize Cargo.toml
f0e176a
@TimTheBig
Document code
3b6e3f9
@TimTheBig
Organize and improve code
fbc3eb6
@TimTheBig
Move shapes to a different file
fafaf34
@TimTheBig
Automatically use wasm deps
72c1718
@TimTheBig
Improve formatting
b4d3cbe
@TimTheBig
Add docs with images
d58ff13 
and document sdf
@TimTheBig
Improve docs
67a3a17
@TimTheBig
Format code
82cf8ff
@TimTheBig
Use thiserror for ValidationError
ecd0744
@TimTheBig
Use crates.io version of dependencies
8e5de99
@TimTheBig
Document font mods
1f10500
@TimTheBig
Add shields to readme
0ffdbce
@TimTheBig
Fix doctests
680f413
@TimTheBig
Rename Plane w to intercept
944c5b7
@TimTheBig
Update Cargo.lock
13c4e36
@TimTheBig
Fix svg
0f46478
@TimTheBig
Add prelude and make metadata default to ()
5a518c5
@TimTheBig
Start move of main to examples
3002796
@TimTheBig
Move more examples
70304a5
@TimTheBig
Improve efficiency
85bfeeb
@TimTheBig
Add error handling
69a528f 
Also improve use of compile-time guaranties
@TimTheBig TimTheBig mentioned this pull request Apr 10, 2025
Merged
@timschmidt
Copy link
Owner

Do you have Discord, Signal, IRC, or some other way to chat interactively? I'd like to discuss some of this.

@TimTheBig
Copy link
Contributor Author

TimTheBig commented Apr 11, 2025 •
edited
Loading

Do you have Discord, Signal, IRC, or some other way to chat interactively? I'd like to discuss some of this.

Signal not sure how to share it privately

@timschmidt
Copy link
Owner

my email is timschmidt at gmail. You can send it there.

@TimTheBig
Copy link
Contributor Author

TimTheBig commented Apr 12, 2025 •
edited
Loading

Remaining tasks:

  • Document the rest of the data-structures and modules
  • Move the rest of the examples
  • Cleanup readme, moving some info to other files
  • Make offset also act on projected 3d polygons

@timschmidt
Copy link
Owner

@timschmidt did you get the email I sent?

not yet

@TimTheBig
Copy link
Contributor Author

I sent it to the wrong email, you should have it now

@timschmidt
Copy link
Owner

Received. Message sent.

@TimTheBig TimTheBig marked this pull request as ready for review April 20, 2025 19:14
@TimTheBig
Copy link
Contributor Author

This ready the remaining tasks will be addressed in a future pr, please release a new version after this pr is merged.

@TimTheBig
Copy link
Contributor Author

I will fix conflicts tomorrow

timschmidt
timschmidt reviewed Jun 9, 2025
View reviewed changes
docs/convex_hull.svg
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with csgrs-generated graphic or remove.

timschmidt
timschmidt reviewed Jun 9, 2025
View reviewed changes
docs/metaballs.png
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with csgrs-generated graphic or remove.

timschmidt
timschmidt reviewed Jun 9, 2025
View reviewed changes
docs/signed_distance_field.gif
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with csgrs-generated graphic or remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave it out for now, same for all above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timschmidt timschmidt timschmidt left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimTheBig @timschmidt