[pull] master from robotframework:master #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://master-n02a3.squash.io |
One less thing for linters to complain.
It probably was useful when we supported Jython, but it's not useful anymore.
Previous messages weren't restored meaning that messages could be lost. The unused variable also made linters unhappy. This code attemps to avoid problems with timeouts interrupting writing to output files. The current code was written to fix #5395 and is basically a rewrite of the fix for #2839. As #5417 explains, there are still problems and bigger changes are needed.
This is a huge commit containing following changes: - Code formatting with Black. This includes changing quote styles from single quotes to double quotes. - Linting with Ruff and fixing found issues. - Import sorting and cleanup with Ruff. - Reorganization of multiline imports with isort. Imports that are part of public APIs are excluded. - Manual inspection of all changes. Includes refactoring to make formatting better and some usages of `# fmt: skip`. - Converting string formatting to use f-strings consistently. - Configuration for Black, Ruff and isort in `pyproject.toml`. - Invoke task `invoke format` for running the whole formatting process. This formatting is done only for `src`, `atest` and `utest` directories, but the task allows formatting also other files.
Bumps the npm_and_yarn group with 1 update in the /src/web directory: [base-x](https://github.com/cryptocoinjs/base-x). Updates `base-x` from 3.0.9 to 3.0.11 - [Commits](cryptocoinjs/base-x@v3.0.9...v3.0.11) --- updated-dependencies: - dependency-name: base-x dependency-version: 3.0.11 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
GitHub will ignore commits in this file by defaul and Git can be configured to ignore them locally as well. Initially contains the code formatting commit done as part of #5387. More commits, also past ones, can be added later if needed.
Nested timeouts occur if a library keyword uses `BuiltIn.run_keyword`. Fixes #5422. Also unregister signal handler we have assigned to SIGALRM. Earlier only the timer was deactivated.
- Move high level timeout implementation from `__init__.py` to `timeout.py`. - Make it an error to start or otherwise interact with inactive timeouts. - Rename platform specific timeout classes to from `Timeout` to `<Platform>Runner`. - Create common base class for runners. - Add `Timeout.get_runner()` for getting a runner. This can be used later to get an access to a runner to be able to pause it (#5417). - Preserve `Timeout.run()` as a convenience method. - Remove locking and `_finished` flag from Windows implementation. They didn't seem to be actually needed, and also the commit were they were added mentioned that the fixed issue didn't really require them. See 1a5eeaa.
This prevents timeouts occurring when Robot is writing output files and thus avoids output files getting corrupted. Fixes #5417. Thanks to the refactoring in the previous commit, implementation is relatively simple. Also make sure delayed messages (#2839) are logged in correct order when `BuiltIn.run_keyword` is used. Fixes #5423.
…src/web/npm_and_yarn-7ad2ad6968 Bump base-x from 3.0.9 to 3.0.11 in /src/web in the npm_and_yarn group across 1 directory
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.4.0 to 5.6.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5.4.0...v5.6.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: 5.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… error` section. (#5388)
Normal type hints should be used instead. Part of #3278.
This documentation was added as part of #5396.
- Document the ERROR level under the Log levels section. - Clarify documentation related to logging with the ERROR level when `--exit-on-error` is enabled. - Explain that TRY/EXCEPT cannot catch errors stopping the whole execution. Fixes #5424.
Part of #5373.
This seems to be the recommended naming style for type aliases. Old name is preserved for backwards compatibility reasons for now.
Make it more explicit that `Run`, `Run And Return RC` and `Run And Returcn RC And Output` are considered deprecated and the Process library should be used instead. Especially `Run` is so widely used that we cannot remove or even loudly deprecate it yet. Fixes #5535.
It seemed to be impossible the get the granurality needed for whitespaces with tempaltes, fallback to render with TS.
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The new libdoc build pipeline optimizes html so that attributes are not quoted. Take that inot account when writing generator information.
…s/actions/setup-node-6 Bump actions/setup-node from 5 to 6
There are use cases for printing a warning or error message to the log but not to the console. This commit adds an optional also_console argument to logger.write, logger.warn, and logger.error. Its value is stored in the message object and based on it the loggers in src/robot/output/console/ print the message or not. Fixes #5460. * atest: Update "Write messages to console" test Messages logged with `also_console=True` are now printed to stderr instead of stdout (see previous commit). * atest: Test writing warning and error messages only to log
- Rename `also_console` argument to `console`. Preserve the old argument with `robot.api.logger.info` for backwards compatibility reasons for now. - Enhance argument documentation in `robot.api.logger`. - When writing normal messages (i.e. not warnings or errors) to console, always write them to `stdout` and never use extra prefix. This was a bug in PR #5462. - Write normal messages to console in a single place. - Enhance `Log` so that it can log warnings and errors so that they aren't written to console. - Use standard ValueError, not DataError, if log level is invalid. Related to issue #5460.
Mostly cleanup. In some cases tests were also enhanced to validate more values.
Also fix failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )