Porting Dynamic_Update_Slice operator from TFLite #3246
Conversation
Sync changes
| } | ||
| } | ||
|
|
||
| // TODO(rameshkunasi): Add quantized test for dynamic update slice. |
There was a problem hiding this comment.
Are you planning to add this in the separate PR?
There was a problem hiding this comment.
Thank you for finding this. For this kernel quantized test is not required. Added remaining test
|
|
||
| // min/max are used to compute scale, zero-point is 0 | ||
| template <size_t kInputSize> | ||
| struct TestDynamicUpdateSliceParams { |
There was a problem hiding this comment.
Not useful. Removed
| namespace testing { | ||
| namespace { | ||
|
|
||
| // constexpr float kTestTolerance = 7.41e-03; |
There was a problem hiding this comment.
Not required. Removed
| kInputDims_0, kInputDims_1, kInputDims_2}; | ||
| int kOutputDims[] = {2, 3, 3}; | ||
|
|
||
| constexpr float kInput_0[] = {1, 2, 3, 4, 5, 6, 7, 8, 9}; |
There was a problem hiding this comment.
Maybe I missed something here; The dimension for this is defined {2, 3, 3} above but the array here only has 9 elements? Where is the remaining half?
There was a problem hiding this comment.
@veblush kOutputDims is a stand-in array for TfLiteIntArray. The first element of the array is the number of array elements. This occurs throughout the unit tests (using IntArrayFromInts). TfLiteFloatArray is even hairier as the first element of the float array has to be rewritten as an int by FloatArrayFromFloats...
| TF_LITE_ENSURE(context, | ||
| SizeOfDimension(update, i) <= SizeOfDimension(operand, i)); | ||
| } | ||
| output->type = operand->type; |
There was a problem hiding this comment.
I'm curious what's the purpose of this? Output tensor will be deallocated right away?
There was a problem hiding this comment.
@rameshkunasi I am also curious as to why the output tensor type is not already set by the TfLiteConverter?
There was a problem hiding this comment.
Thank you for pointing this. Not required, removed this
| output_data); | ||
| } | ||
|
|
||
| TF_LITE_MICRO_TEST(DynamicUpdateSliceOpTestBoundaryTest) { |
There was a problem hiding this comment.
What's the purpose of this test? How is this different from DynamicUpdateSliceOpTestSimpleFloat?
There was a problem hiding this comment.
It is same as DynamicUpdateSliceOpTestSimpleFloat except the indices. Here in this test indices used are corner case
| if (current_dim == max_dims) { | ||
| return kTfLiteOk; | ||
| } |
There was a problem hiding this comment.
I guess this is unreachable?
There was a problem hiding this comment.
It will, because it will be called by increasing current_dim count in recursively
4 participants
Added Dynamic_Update_Slice operator changes.
BUG=fixes #3217