Skip to content

Conversation

@aardvark179
Copy link
Contributor

Add a test for doing Object.assign with an array target. We saw a bug in Rhino where this had been implemented in a subtly wrong way, and I was surprised to see no test case for many of the exotic object types.

@aardvark179 aardvark179 requested a review from a team as a code owner October 22, 2025 10:22
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should also add a separate test where you assign an object with non-array-index properties onto an array?

@gibson042 gibson042 force-pushed the aardvark179-Object-assign-array-test branch from 77c0c50 to 119619d Compare October 29, 2025 20:03
@gibson042 gibson042 merged commit c588df6 into tc39:main Oct 29, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants