- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5k
 
feat: add FORCE option for compact command #33427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0
Are you sure you want to change the base?
Conversation
          Summary of ChangesHello @hzcheng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new  Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a FORCE option for the COMPACT command, allowing compaction to run even if no new data has been written. The changes are implemented consistently across the stack, from the SQL parser to the underlying storage message formats. The code modifications are correct and handle backward compatibility for message formats properly. I have one suggestion to improve the wording in the English documentation for better clarity.
| - You can specify the start time of the COMPACT data with the start with keyword | ||
| - You can specify the end time of the COMPACT data with the end with keyword | ||
| - You can specify the META_ONLY keyword to only compact the meta data which are not compacted by default. Meta data compaction can block write and the database compacting meta should stop write and query | ||
| - The file group will not compact if no new data is written since the last compact unless the FORCE keyword is specified | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording of this sentence could be improved for clarity. Consider rephrasing to make it more natural for English readers.
| - The file group will not compact if no new data is written since the last compact unless the FORCE keyword is specified | |
| - A file group will not be compacted if no new data has been written since the last compaction, unless the FORCE keyword is specified | 
…hzcheng/3.0/TS-7540
Description
Please briefly describe the code changes in this pull request.
Checklist
Please check the items in the checklist if applicable.