MicroBin中文版v1.2.0 #148
Open
MicroBin中文版v1.2.0 #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbin中文版v1.2.0
…h_CN into microbin-zh_CN
kwiniarski97
suggested changes
Nov 2, 2023
There was a problem hiding this comment.
Hey. I think you put a lot of effort into this. Thank you for this.
There's few problems with this pull request and I think it should never be merged in it's current form.
- You are changing a lot of places in code while this PR should be about translation
- You've changed formatting in lot of places for no particular reason
- If this were merged everyone would be using Chinese microbin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope to be able to translate your project into Chinese so that your MicroBin project can be liked and used by more people. Many Chinese friends are suffering from difficulties in using without Chinese. I hope to make contributions to your project and also hope to receive your support. Thank you.