🍒[clang][DependencyScanning] Implementation of CompilerInstanceWithContext to Improve By-Name Queries #11821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h clang/lib/Frontend/FrontendActions.cpp clang/lib/Tooling/DependencyScanning/DependencyScannerImpl.cpp clang/lib/Tooling/DependencyScanning/DependencyScannerImpl.h clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp clang/tools/clang-scan-deps/ClangScanDeps.cpp (cherry picked from commit 97f12f9) Conflicts: clang/include/clang/Frontend/FrontendActions.h clang/lib/Frontend/FrontendActions.cpp
…preserve the stable dirs and correctly setup the action controller for by name lookups.
This patch fixes: clang/lib/Tooling/DependencyScanning/DependencyScannerImpl.cpp:733:10: error: unused variable 'ArgSize' [-Werror,-Wunused-variable] clang/lib/Tooling/DependencyScanning/DependencyScannerImpl.cpp:735:15: error: unused variable 'FirstArg' [-Werror,-Wunused-variable] (cherry picked from commit 8552a8f)
Author
|
@swift-ci please test |
Author
|
@swift-ci please test llvm |
qiongsiwu
requested review from
Bigcheese,
benlangmuir,
cachemeifyoucan and
jansvoboda11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks llvm#164345 to
stable/21.x, and fixes two bugs introduced when it was merged intonext.