Network Remote V3 #1747
Network Remote V3 #1747
Conversation
|
I'd appreciate of you could find the time for a review so I can maybe focus on working on some other areas of Strawberry. |
I already reviewed in the previous PR #1688, most of the issues are not addressed. |
|
I don't understand why your merging in a bunch of unrelated commits here, there is no commit here explaining what's being done here. |
|
Commit 8e158ad looks strange, it's a mix my changes and your changes, the text in the commit title is from a different commit, while the commit message body is a mix of different comments. |
|
I think one of the recurring issues seems to be the format of the code. I'm using Qt Creator If you are using CLangFormat settings maybe you can share your .clang_format file If you you are using something else for your development, maybe you can share what that is |
You need to restart Strawberry for this setting to take affect
Renamed classes to be less ambiguous Save before clientmanager changes This works after major change in clientmanager Cleaned up formatting Still works I have fixed most of the code issues apart from the one I commented on where I wasn't sure what was meant or how to resolve the issue. I reformatted all my code and used Qt stringliterals where applicable Cmake now uses Qt Protobuf I removed Application where I could. Still needed where I need acces to the player. All objects should now be freed. I have hardcoded the CMAKE_INSTALL_RPATH as RPATH seems to be a requirement when using Ninja as the cmake generator. Ubuntu currently comes with 6.4.2, but the QtCreator is on 6.8 I'm pulling in the library from the Creator Not sure what you meant by "I think we should use signals/slots to reload settings (like most other places) instead of the singleton" Not sure what the Copyright header should look like. Do I put my name on this? I have not made the Network remote optional yet as I wanted to get the code sorted out first I still have have one outstanding issue on Ubuntu [1276/1276 11.5/sec] Linking CXX executable strawberry /usr/bin/ld: warning: libicui18n.so.73, needed by /home/llist/Qt/6.8.2/gcc_64/lib/libQt6Core.so.6.8.2, may conflict with libicui18n.so.74 /usr/bin/ld: warning: libicuuc.so.73, needed by /home/llist/Qt/6.8.2/gcc_64/lib/libQt6Core.so.6.8.2, may conflict with libicuuc.so.74 Changes requested by maintainer Added Copyright Passing Player instead of Application as an argument Clean code as per maintainers request Using Player rather than Application class to get song data Code cleanup Removed RPATH related entries form cmake file Fixed code as per maintainers reuqest Removed all non essential refererences to a Application from the code Inserted Copyright Stage 1 of making Network Remote optional
poldi171254
force-pushed
the
NWRemoteOptional
branch
from
af9306e to
f9b5b00
Compare
I think I made mistakes when I squashed the commits. Any idea how to fix this? |
|
I've gone through your requests for V2 PR and as far as I can see I've done them all. |
There already is a clang-format file in this repository as I explained here:
|
I'm not sure you can fix it with a normal rebase since you have changed commits that were part of master. |
…le changes This should all be ok now
You need to restart Strawberry for this setting to take affect
I now have a working version with option network remote code. I still need to check the maintainers latest comments.
…into NWRemoteOptional
|
There are two ourstanding issues that need clarification |
|
Can you please review my latest changes |
4 participants
I have now made the Network Remote optional and cleaned up the code as per request.
This replaces V2 pull request.
I tried to close my previous pull request, but can't find a way of doinng this