Mark fields in the runconfig as deprecated #2212
Open
+46
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
force-pushed
the
deprecated-fields
branch
from
2bf7d4b to
784e293
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2212 +/- ##
==========================================
- Coverage 55.01% 54.99% -0.03%
==========================================
Files 292 292
Lines 27904 27904
==========================================
- Hits 15351 15345 -6
- Misses 11144 11156 +12
+ Partials 1409 1403 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This applies to fields which either: - Do not appear to be used any more. - Are replaced by the telemetry middleware. We need to modify k8s to use the telemetry middleware object.
dmjb
force-pushed
the
deprecated-fields
branch
from
784e293 to
36857b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to fields which either:
We need to modify k8s to use the telemetry middleware object.