Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 11, 2025

Description

Part of stackabletech/issues#712
Decision: https://github.com/stackabletech/decisions/issues/64
Needs stackabletech/documentation#807 for the documentation part

The actual code change is oversee-able, most of the added lines are tests.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer marked this pull request as ready for review November 20, 2025 15:24
@sbernauer sbernauer self-assigned this Nov 20, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Nov 20, 2025
@sbernauer sbernauer requested a review from a team November 20, 2025 15:24
@Techassi Techassi self-requested a review November 20, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

2 participants