Change so useReturnTypeSchema is considered on an http code level #3141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l rather than on a method level
Mattias-Sehlstedt
force-pushed
the
use-return-type-schema
branch
from
972934e to
4b50786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3137
The issue reported stem from the fact the the
useReturnTypeSchemacurrently is considered on a method level rather than on an http code level. This means that if several@ApiResponseare defined, then the last annotation determines whether theuseReturnTypeSchemais triggered or not. This will then in turn lead to either all responses calculating the response type or none or them.This change allows the definition to be tied to individual http code definitions, so that for example only the 200 response derives its response type, while any 4xx or 5xx definition can retain strictly an explicit schema implementation.