Skip to content

Conversation

@ilayaperumalg
Copy link
Member

@ilayaperumalg ilayaperumalg commented Nov 7, 2025

Remove deprecated constructors, methods, and classes scheduled for removal:

  • Delete deprecated OllamaOptions class (replaced by OllamaChatOptions/OllamaEmbeddingOptions)
  • Delete deprecated EmbeddingOptionsBuilder class
  • Remove deprecated constructors from:
    • QuestionAnswerAdvisor
    • DeepSeekAssistantMessage
    • MistralAiChatModel, MistralAiEmbeddingModel, MistralAiModerationModel
    • MistralAiApi, MistralAiModerationApi
  • Remove deprecated builder methods:
    • BedrockTitanEmbeddingOptions.Builder.withInputType()
    • OllamaChatModel.Builder.defaultOptions(OllamaOptions)
    • OllamaEmbeddingModel.Builder.defaultOptions(OllamaOptions)

Update all usages throughout codebase:

  • Migrate AssistantMessage construction to builder pattern
  • Replace EmbeddingOptionsBuilder with EmbeddingOptions.builder()
  • Update OllamaOptions references to use specific option types
  • Update vector stores and tests to use builder patterns

Update reference docs to fix the deprecations

  Remove deprecated constructors, methods, and classes scheduled for removal:

  - Delete deprecated OllamaOptions class (replaced by OllamaChatOptions/OllamaEmbeddingOptions)
  - Delete deprecated EmbeddingOptionsBuilder class
  - Remove deprecated constructors from:
    - QuestionAnswerAdvisor
    - DeepSeekAssistantMessage
    - MistralAiChatModel, MistralAiEmbeddingModel, MistralAiModerationModel
    - MistralAiApi, MistralAiModerationApi
  - Remove deprecated builder methods:
    - BedrockTitanEmbeddingOptions.Builder.withInputType()
    - OllamaChatModel.Builder.defaultOptions(OllamaOptions)
    - OllamaEmbeddingModel.Builder.defaultOptions(OllamaOptions)

  Update all usages throughout codebase:
  - Migrate AssistantMessage construction to builder pattern
  - Replace EmbeddingOptionsBuilder with EmbeddingOptions.builder()
  - Update OllamaOptions references to use specific option types
  - Update vector stores and tests to use builder patterns

  Update reference docs to fix the deprecations

Signed-off-by: Ilayaperumal Gopinathan <ilayaperumal.gopinathan@broadcom.com>
@ilayaperumalg ilayaperumalg added this to the 1.1.0.RC1 milestone Nov 7, 2025
@apappascs
Copy link
Contributor

would it make sense to also remove the deprecated classes for TTS? I have the PR open with all related changes including documentation and migration guide:
#4814

@ilayaperumalg
Copy link
Member Author

@apappascs Thanks the heads up! While your changes at #4814 make sense, we are yet to decide whether to bring in such breaking changes as we are so close to do 1.1.0 GA.

@apappascs
Copy link
Contributor

@ilayaperumalg Totally understand the timing concern being so close to 1.1.0 GA.
The TTS changes in #4814 follow the same pattern you're applying here.. removing deprecated classes and migrating to the shared interface approach. Since we already have the shared TextToSpeechModel interface established and the OpenAI specific classes deprecated, it felt like a natural fit for the 1.1.0 cleanup.
That said, I'm happy to hold off if the team prefers to defer breaking changes.

Copy link
Member

@ericbottard ericbottard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although some removals where since=1.1.0 make seem like we're being a bit aggressive (but this doesn't mean others without the attribute weren't introduced in early 1.1.0 too)

@ilayaperumalg
Copy link
Member Author

@apappascs we have decided to get your changes from #4814 in for 1.1.0.

@markpollack
Copy link
Member

merged in c631340

@markpollack markpollack closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants