perform filesystem R/W checks at startup #10177
Draft
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
later when actual writes are performed (e.g. spesmilo#4151)
zrawsig
reviewed
Oct 1, 2025
| for f in ['config', 'blockchain_headers', 'recent_servers']: | ||
| fpath = os.path.join(electrum_path, f) | ||
| if os.path.exists(fpath): | ||
| if not os.access(fpath, os.R_OK | os.W_OK): |
There was a problem hiding this comment.
The os.access() check is repeated a few times with the exception message.
This could be factored out to improve readability, for example:
def check_permissions(path: str):
if not os.access(path, os.R_OK | os.W_OK):
raise Exception(f'Cannot read/write {path}')| def check_fs_permissions(config: 'SimpleConfig'): | ||
| electrum_path = config.electrum_path() | ||
| if not os.access(electrum_path, os.R_OK | os.W_OK): | ||
| raise Exception('can not read/write root folder at ' + electrum_path) |
There was a problem hiding this comment.
"can not" is grammatically incorrect, please change to "Cannot". See the factored out example above.
| util.trigger_callback('recently_opened_wallets_update') | ||
|
|
||
|
|
||
| def check_fs_permissions(config: 'SimpleConfig'): |
There was a problem hiding this comment.
This is the only function below the classes, while other generic functions such as this one lives in the beginning of the file. Maybe it could be moved there to keep the file organized that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perform filesystem R/W checks at startup. This avoids raising Exceptions later when actual writes are performed (e.g. #4151).
Not sure yet how portable this is, needs testing on win and mac