feat: add support for codeblock on iOS #253
Conversation
| return NO; | ||
| } | ||
|
|
||
| + (BOOL)handleNewlineBackspaceInRange:(NSRange)range replacementText:(NSString *)text input:(id)input { |
There was a problem hiding this comment.
Let's add some verbose comment what that function does and why it needs to run as a last of the callbacks
There was a problem hiding this comment.
I add comment with explanation. What do you think?
| ]; | ||
|
|
||
| return manualLinkRange.length == 0 ? automaticLinkRange : manualLinkRange; | ||
| return manualUrl == nil ? automaticLinkRange : manualLinkRange; |
There was a problem hiding this comment.
For the sake of safety I'd also assign automaticUrl to the automatic link range search result and do something like;
| return manualUrl == nil ? automaticLinkRange : manualLinkRange; | |
| return | |
| manualLink == nullptr | |
| ? automaticLink == nullptr ? NSMakeRange(0,0) : automaticLinkRange | |
| : manualLinkRange; |
There was a problem hiding this comment.
It shouldn't happen but if the internals of some iOS function change again it will be less chaotic (:
| withInput:(EnrichedTextInputView* _Nonnull)input | ||
| inRange:(NSRange)range | ||
| withCondition:(BOOL (NS_NOESCAPE ^_Nonnull)(id _Nullable value, NSRange range))condition; | ||
| + (NSArray *_Nonnull)getRangesWithout:(NSArray<NSNumber *> *_Nonnull)types withInput:(EnrichedTextInputView* _Nonnull)input |
There was a problem hiding this comment.
Could you please spread the arguments into different lines as in all the other functions?
| return occurences; | ||
| } | ||
|
|
||
| + (NSArray *_Nonnull)getRangesWithout:(NSArray<NSNumber *> *_Nonnull)types withInput:(EnrichedTextInputView* _Nonnull)input |
There was a problem hiding this comment.
Arguments spreading would also be cool here if we keep it that way in the file. Some objc linter will eventually fix it though so not a big deal 😄
2 participants
Summary
Add support for
codeblock.Test Plan
Run Example app and play with
codeblockScreenshots
Compatibility