Skip to content

Conversation

@zpoint
Copy link
Collaborator

@zpoint zpoint commented Oct 31, 2025

Resolve #7807

This PR fixed test_volume_env_mount_kubernetes and test_managed_jobs_ha_kill_running and --remote-server

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@zpoint
Copy link
Collaborator Author

zpoint commented Oct 31, 2025

/smoke-test -k test_managed_jobs_ha_kill_starting --kubernetes
/smoke-test -k test_managed_jobs_ha_kill_running --kubernetes
/smoke-test -k test_volume_env_mount_kubernetes --kubernetes
/smoke-test -k test_recent_request_tracking --kubernetes --remote-server

@zpoint
Copy link
Collaborator Author

zpoint commented Oct 31, 2025

/smoke-test -k test_managed_jobs_ha_kill_starting --kubernetes
/smoke-test -k test_managed_jobs_ha_kill_running --kubernetes
/smoke-test -k test_volume_env_mount_kubernetes --kubernetes
/smoke-test -k test_recent_request_tracking --kubernetes --remote-server

Copy link
Collaborator

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zpoint zpoint merged commit b8fa056 into skypilot-org:master Oct 31, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly build failures

3 participants