hacktoberfest: Added sites support #2710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic validation of changes
|
Automatic validation of changes
|
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Automatic validation of changes
|
Aaditya-Chunekar
changed the title
|
LGTM. If you don't mind, could you clean up the commit history with the following? Not ideal having so many commits per minor change. Muddies the log. Added the accepted tag so it counts as of this moment, despite pending: (assuming master is up to date and your data.json doesn't have random extra changes) git reset --hard $(git merge-base master HEAD)
git checkout 13159ad -- sherlock_project/resources/data.json
git commit -m "feat: add n8n, HackerSploit, Arduino Forum"
git push --force-with-leaseRecommend saving elsewhere if unsure. Let me know if you have any issues. (argument exists for three commits, but I don't care here, they all work) |
Automatic validation of changes
|
Aaditya-Chunekar
force-pushed
the
add-sites
branch
from
85341a7 to
9bafb8a
Compare
Automatic validation of changes
|
Automatic validation of changes
|
Aaditya-Chunekar
force-pushed
the
add-sites
branch
from
de6e338 to
259b4ab
Compare
Aaditya-Chunekar
force-pushed
the
add-sites
branch
from
259b4ab to
2724711
Compare
Automatic validation of changes
|
|
Huh. Thought I merged this. Well it's merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: