Skip to content

Conversation

@dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Oct 15, 2025

Add Python 3.14 to supported list and start testing it.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev dkropachev force-pushed the dk/add-python-3.14-support branch 2 times, most recently from 7769379 to 206bf79 Compare October 16, 2025 16:45
@dkropachev
Copy link
Collaborator Author

Just to keep updated, by some reason instead of asincio and libev it uses twisted which uses zope, which does not support python 3.14 and fails by this reason.

@fruch
Copy link

fruch commented Nov 17, 2025

@dkropachev what's holding this one out of the door ?

@fruch
Copy link

fruch commented Nov 17, 2025

@dkropachev how about adding 3.14t ? into testing only

@dkropachev
Copy link
Collaborator Author

@fruch , lets fix ongling cicd problem first

@dkropachev dkropachev force-pushed the dk/add-python-3.14-support branch from 206bf79 to ee47b3d Compare November 17, 2025 16:29
@dkropachev dkropachev marked this pull request as ready for review November 18, 2025 04:21
@dkropachev dkropachev force-pushed the dk/add-python-3.14-support branch 2 times, most recently from d99ae85 to ef90c56 Compare November 18, 2025 18:05
@dkropachev
Copy link
Collaborator Author

@fruch , @Lorak-mmk , after all issues were sorted out in separate PRs this one looks so much cleaner, please take a look.

@dkropachev dkropachev self-assigned this Nov 18, 2025
@dkropachev dkropachev force-pushed the dk/add-python-3.14-support branch 2 times, most recently from 7bd6af5 to b07f6f7 Compare November 18, 2025 19:53
@dkropachev
Copy link
Collaborator Author

@Lorak-mmk , can you please review it

Copy link

@Lorak-mmk Lorak-mmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@fruch
Copy link

fruch commented Nov 20, 2025

  • pp311-manylinux_x86_64 wheel failed - can we ditch pypy builds in general ?
  • windows 3.14t - greenlet_msvc_compat.hpp(70): error C3861: '_PyCode_GetTLBCArray': identifier not found

I would suggest taking 3.14t to a followup PR

1. Add integration tests to CICD
2. Update documentation and pyproject.toml
@dkropachev dkropachev force-pushed the dk/add-python-3.14-support branch from b07f6f7 to 924492a Compare November 21, 2025 11:05
@dkropachev
Copy link
Collaborator Author

dkropachev commented Nov 21, 2025

  • pp311-manylinux_x86_64 wheel failed - can we ditch pypy builds in general ?
  • windows 3.14t - greenlet_msvc_compat.hpp(70): error C3861: '_PyCode_GetTLBCArray': identifier not found

I would suggest taking 3.14t to a followup PR

Done, created an issue on that - #599

@dkropachev dkropachev merged commit 5309326 into scylladb:master Nov 21, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants