- 
                Notifications
    
You must be signed in to change notification settings  - Fork 177
 
perf: add ability to write downcasted indices #2159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main    #2159      +/-   ##
==========================================
- Coverage   84.77%   84.65%   -0.12%     
==========================================
  Files          46       46              
  Lines        7132     7142      +10     
==========================================
  Hits         6046     6046              
- Misses       1086     1096      +10     
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
When reading this in, will the dtype be preserved? And if so, how do certain APIs deal with tiny int dtypes? Like anndata’s concatenation and scanpy’s algorithms?
          
 
  | 
    
Co-authored-by: Philipp A. <flying-sheep@web.de>
          
Benchmark changes
 Comparison: https://github.com/scverse/anndata/compare/5212db80485432719021445084d93407c0ce11b2..1361d36a4dd2e4bc20dfe3f89f03369f131be637 More details: https://github.com/scverse/anndata/pull/2159/checks?check_run_id=54361625499  | 
    
TODO:
indicesfor sparse matrices if possible on-disk #2153tests for + run on GPU CIWe don't support io directly into GPU anyway!Checks
indicesfor sparse matrices if possible on-disk #2153