-
Notifications
You must be signed in to change notification settings - Fork 9
New workspace flow #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cation should now work
… checking). begin to look for `start` argument of pathspec
…ate it. fixed up garbage collecting
|
Diagram, courtesy of ChatGPT |
on disk layout |
|
Currently running Alegra's nightly tests. |
|
Workflow for running night tests: Some notes:
|
|
I just re-read @mdmosby document above and noticed that I used the name |
|
So the nightly tests ran great. About 5000 passed fine. 80 failed. The 80 that failed are at the end of a complicated dependency chain. I'll have to do a bit more investigating to determine the root cause. If all of Alegra's tests can pass with the new workflow I'd say that constitutes completion of the technical implementation. |
|
Superseded by #67 |
This PR implements an updated workflow as described in https://github.com/sandialabs/canary/blob/tjfulle/repo-layout/workspace-cmd-spec.md
The problem
The current behavior of Canary is to create a
TestResultsdirectory and in it, a.canarydirectory. All tests are run in theTestResultsdirectory and configurations, options, metadata stored inTestResults/.canary. The test results directory is mutable: future test runs simply updated the previous results. To rerun tests, create reports from previous results, etc.,canarymust be invoked inside the test directory. In this case,canarycan recover the previous settings and test results.Three helper flags aid with this workflow:
run -d PATHcausescanaryto write test results toPATHinstead ofTestResults;run -wcausescanaryto remove the test results directory before execution; and-C PATHcausescanaryto navigate toPATHbefore processing the command line.More concretely:
Feedback from Sierra developers indicated that this was confusing. Particularly the interaction between the
-C,-d, and-wflags.Introduction the Canary Workspace
This PR refactors
canaryaway from the above workflow. Rather than describe the workflow, we show itThe new workflow:
This demonstrates a very simple workflow where generators are added, test cases generated, and run. The new workflow allows for far more flexibility:
Some implementation details
canary initcreates the Canary "workspace" in$PWD/.canary.canary runcreates a newSessionwhose results are kept in.canary/sessions/SESSION_IDcanarykeeps a database of all of the latest test results across all test sessions.To do