uefi: add high-level TCP wrapper #1798
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayKickliter
force-pushed
the
jsk/uefi/add-tcpv4
branch
from
b692b35 to
e130f46
Compare
Member
|
typically we mark PRs as draft when they wait to be rebased onto another PR - so I marked this PR as draft. Thanks for working on this and splitting this into multiple PRs! |
phip1611
reviewed
Oct 22, 2025
phip1611
requested changes
Oct 22, 2025
JayKickliter
force-pushed
the
jsk/uefi/add-tcpv4
branch
4 times, most recently
from
ebf20de to
dee28f7
Compare
JayKickliter
force-pushed
the
jsk/uefi/add-tcpv4
branch
2 times, most recently
from
05b5155 to
f547536
Compare
JayKickliter
commented
Nov 11, 2025
|
|
||
| impl Tcp4 { | ||
| /// See [Tcp4Protocol::configure]. | ||
| pub fn configure(&mut self, config: &ConfigData, options: Option<&ConfigOptions>) -> Result { |
Author
There was a problem hiding this comment.
I just realize this fn duplicates a lot of Ip4Config2::ifup() . Should I just make Tcp4 take a NIC Handle that's already been configured like Http does?
Member
There was a problem hiding this comment.
makes sense. in uefi, we prefer to hide lower-level details of UEFI from public API. Convenient high-level abstractions are very appreciated
JayKickliter
force-pushed
the
jsk/uefi/add-tcpv4
branch
3 times, most recently
from
6e51b3d to
327b902
Compare
JayKickliter
force-pushed
the
jsk/uefi/add-tcpv4
branch
from
327b902 to
7d9befe
Compare
Member
|
#1797 is merged, please rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 2 of 2 adding TCP to uefi-rs, and is a replacement for #1779. Note that this PR contains the commits from #1797 and will need to rebased before merging.
TODO before merging
uefi-rawrelative path dep inuefi/Cargo.tomlto point to publusheduefi-rawcrate.Checklist