Skip to content

Fix updownstatus API lambda handler export #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix updownstatus API lambda handler export #33

wants to merge 1 commit into from

Conversation

@rjaduthie
Copy link
Contributor

Addresses Issue #32

This was referenced Jan 20, 2023
Open
Open
@rjaduthie
Copy link
Contributor Author

Talking to my colleague who's much more knowledgable on TS: a potentially better way to fix this would be to change the export default to a export const; the problem is probably due to the former not exporting the reference. I'll give it a go and amend the PR.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rjaduthie
Copy link
Contributor Author

Amended the change to use a nice syntax. Thank you to @jonathonhawkins92 for the advice.

giantcow
giantcow approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@giantcow giantcow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw this can also be solved by removing the default keyword This is what you said in the second comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@giantcow giantcow giantcow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rjaduthie @giantcow