Skip to content

Remove unused args in urlTransform #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove unused args in urlTransform #910

wants to merge 1 commit into from

Conversation

@whatisagi
Copy link

@whatisagi whatisagi commented Apr 18, 2025 •
edited
Loading

Initial checklist

  • [ x] I read the support docs
  • [x ] I read the contributing guide
  • [ x] I agree to follow the code of conduct
  • [ x] I searched issues and discussions and couldn’t find anything or linked relevant results below
  • [x ] I made sure the docs are up to date
  • [ x] I included tests (or that’s not needed)

Description of changes

This PR removes the unused args when calling urlTransform.

@whatisagi
Remove unused args in urlTransform
ff666f7 
Signed-off-by: TN <128629064+whatisagi@users.noreply.github.com>
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Apr 18, 2025
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Apr 18, 2025
@whatisagi
Copy link
Author

whatisagi commented Apr 18, 2025

Uhm I think I understand now, custom urlTransform potentially needs key and node.

@whatisagi whatisagi closed this Apr 18, 2025
@github-actions

This comment has been minimized.

Sign in to view
@ChristianMurphy ChristianMurphy added the 🤷 no/invalid This cannot be acted upon label Apr 18, 2025
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whatisagi @ChristianMurphy